Fix nontemporal stores on non-x86 for fields with variable size
Fix the issue discussed in walberla/walberla!553 (comment 19202)
Merge request reports
Activity
assigned to @holzer
added 3 commits
-
67c3f7bb...205d0a39 - 2 commits from branch
master
- a4d16275 - Fix nontemporal stores on non-x86 for fields with variable size
-
67c3f7bb...205d0a39 - 2 commits from branch
I just found this merge request again and looked at why three tests were failing. These tests use
Field.create_generic("buffer", spatial_dimensions=1, index_dimensions=1, field_type=FieldType.BUFFER
). The resulting field still has 2-dimensional indexing, but the array created later by the datahandling only has 1-dimensional, so getting its size along the second axis fails. I did not even know we supported 1-dimensional fields. Note that test_buffer_gpu.py has several tests that look similar but don't haveindex_dimensions=1
, so perhaps it's related to the index dimensions. In either case, it seems like it's the fault of the test and not the fault of my merge request. I'll see if I can get modify the test to consistently use 1 dimension.added 4 commits
-
a4d16275...67019520 - 2 commits from branch
master
- b4534227 - Restore support for 1-dimensional fields broken by previous commit
- 040040c7 - Merge remote-tracking branch 'origin/master' into nontemporal
-
a4d16275...67019520 - 2 commits from branch
added 1 commit
- df7c6e75 - Fix storeAAndFlushCacheline when multiple assignments are in the same scope
Fixed. Can you please review this merge request, @holzer?
mentioned in commit b1308c07
mentioned in merge request !302 (closed)
mentioned in merge request !303 (merged)
mentioned in commit 9d9919ff